Add Django 2.2 and Python 3.8 to CI config #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like that's a no. @owais any insight or advice? Also, I'm surprised to see the |
Collaborator
|
Looks like URLs in test app are not defined the way django 2.2 expects them to be. |
Contributor
Author
|
@owais Thanks for the tip! Looks like this is passing now, except for those mysterious Side note: it was neat to use the CircleCI CLI to verify this locally: |
Collaborator
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I'm crossing my fingers that this works, to support an upgrade that I'm currently doing. These seemed more expedient (and useful) than running the tests locally. That said, I've never used CircleCI, so it's possible it will break due to an error on my part.
The Django 2.2 jobs also use a more recent version of django-jinja for better compatibility (changelog)